07/10: gnu: bandage: Do not yet use the 'imagemagick/stable' variant.

[guix-commits]

apteryx pushed a commit to branch core-updates
in repository guix.

commit f4a76d6ca2d2811970fc94c9120fc05024648f2b
Author: Maxime Devos <maximedevos@telenet.be>
AuthorDate: Mon Mar 29 17:46:36 2021 +0200

    gnu: bandage: Do not yet use the 'imagemagick/stable' variant.
    
    Once <https://issues.guix.gnu.org/47475> (‘Closure of bandage is way too
    large’) has been fixed, the variant will probably be usable.
    
    * gnu/packages/bioinformatics.scm (bandage):
    [arguments]<#:disallowed-references>: Once the issue
    has been fixed, prevent the imagemagick/stable package from ending up in the
    closure.
    [native-inputs]: Note that 'imagemagick/stable' cannot be used yet.
    
    Signed-off-by: Maxim Cournoyer <maxim.cournoyer@gmail.com>
    Modified-by: Maxim Cournoyer <maxim.cournoyer@gmail.com>
    Change-Id: Ie13100eb424b14971055ff91db49bc7029cb6168
---
 gnu/packages/bioinformatics.scm | 46 +++++++++++++++++++++++------------------
 1 file changed, 26 insertions(+), 20 deletions(-)

diff --git a/gnu/packages/bioinformatics.scm b/gnu/packages/bioinformatics.scm
index 173b488c3d..4c6db1da6b 100644
--- a/gnu/packages/bioinformatics.scm
+++ b/gnu/packages/bioinformatics.scm
@@ -15613,29 +15613,35 @@ Thus the per-base error rate is similar to the raw 
input reads.")
         (base32 "1bbsn5f5x8wlspg4pbibqz6m5vin8c19nl224f3z3km0pkc97rwv"))))
     (build-system qt-build-system)
     (arguments
-     `(#:phases
-       (modify-phases %standard-phases
-         (replace 'configure
-           (lambda _
-             (invoke "qmake" "Bandage.pro")))
-         (replace 'check
-           (lambda* (#:key tests? #:allow-other-keys)
-             (when tests?
-               (substitute* "tests/bandage_command_line_tests.sh"
-                 (("^bandagepath=.*")
-                  (string-append "bandagepath=" (getcwd) "/Bandage\n")))
-               (with-directory-excursion "tests"
-                 (setenv "XDG_RUNTIME_DIR" (getcwd))
-                 (invoke "./bandage_command_line_tests.sh")))
-             #t))
-         (replace 'install
-           (lambda* (#:key outputs #:allow-other-keys)
-             (let ((out (assoc-ref outputs "out")))
-               (install-file "Bandage" (string-append out "/bin"))
-               #t))))))
+     (list
+      ;; TODO: Once <https://issues.guix.gnu.org/47475> is fixed,
+      ;; consider uncommenting the following:
+      ;;
+      ;; Prevent the (rarely updated) imagemagick/stable package from
+      ;; ending up in the closure.
+      ;; #:disallowed-references (list imagemagick/stable)
+      #:phases
+      #~(modify-phases %standard-phases
+          (replace 'configure
+            (lambda _
+              (invoke "qmake" "Bandage.pro")))
+          (replace 'check
+            (lambda* (#:key tests? #:allow-other-keys)
+              (when tests?
+                (substitute* "tests/bandage_command_line_tests.sh"
+                  (("^bandagepath=.*")
+                   (string-append "bandagepath=" (getcwd) "/Bandage\n")))
+                (with-directory-excursion "tests"
+                  (setenv "XDG_RUNTIME_DIR" (getcwd))
+                  (invoke "./bandage_command_line_tests.sh")))))
+          (replace 'install
+            (lambda _
+              (install-file "Bandage" (string-append #$output "/bin")))))))
     (inputs
      (list qtbase-5 qtsvg-5))
     (native-inputs
+     ;; imagemagick/stable cannot be used here, as it will end up in
+     ;; the closure.  See <https://issues.guix.gnu.org/47475>.
      (list imagemagick))
     (home-page "https://rrwick.github.io/Bandage/";)
     (synopsis