Re: 02/02: services: docker: Depend on elogind.

[Ludovic Courtès]

address@hidden skribis:

> commit f946a370edbf65baab41e8373e25157da5029a88
> Author: Danny Milosavljevic <address@hidden>
> Date:   Thu Jan 10 05:14:43 2019 +0100
>
>     services: docker: Depend on elogind.
>     
>     * gnu/services/docker.scm (docker-shepherd-service)[requirement]: Add 
> elogind.
> ---
>  gnu/services/docker.scm | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/services/docker.scm b/gnu/services/docker.scm
> index c88fc34..9e24bcd 100644
> --- a/gnu/services/docker.scm
> +++ b/gnu/services/docker.scm
> @@ -70,7 +70,8 @@
>      (shepherd-service
>             (documentation "Docker daemon.")
>             (provision '(dockerd))
> -           (requirement '(containerd))
> +           ;; Note: elogind is required because it's mounting the cgroups.
> +           (requirement '(containerd elogind))

Cgroup file systems are mounted by the corresponding file system
services:

--8<---------------cut here---------------start------------->8---
$ sudo herd status | grep cgroup
 + file-system-/sys/fs/cgroup
 + file-system-/sys/fs/cgroup/blkio
 + file-system-/sys/fs/cgroup/cpu
 + file-system-/sys/fs/cgroup/cpuacct
 + file-system-/sys/fs/cgroup/cpuset
 + file-system-/sys/fs/cgroup/devices
 + file-system-/sys/fs/cgroup/elogind
 + file-system-/sys/fs/cgroup/freezer
 + file-system-/sys/fs/cgroup/memory
 + file-system-/sys/fs/cgroup/perf_event
--8<---------------cut here---------------end--------------->8---

Should it depend on ‘file-system-/sys/fs/cgroup/elogind’, or maybe both
‘elogind’ and ‘file-system-/sys/fs/cgroup/elogind’?  Depends on what it
expects from elogind I guess…

Ludo’.