Re: 177/332: gnu: Add qtvirtualkeyboard-5.

[Maxim Cournoyer]

Hi,

guix-commits@gnu.org writes:

> iyzsong pushed a commit to branch kde-updates
> in repository guix.
>
> commit f370b61078dd0863631433f43d229196d5dc86a7
> Author: Zheng Junjie <873216071@qq.com>
> AuthorDate: Fri Jul 21 19:54:46 2023 +0800
>
>     gnu: Add qtvirtualkeyboard-5.
>     
>     * gnu/packages/qt.scm (qtvirtualkeyboard-5): New variable.

[...]

> +(define-public qtvirtualkeyboard-5
> +  (package
> +    (inherit qtsvg-5)
> +    (name "qtvirtualkeyboard")
> +    (version %qt-version)
> +    (source (origin
> +              (method url-fetch)
> +              (uri (qt-urls name version))
> +              (sha256
> +               (base32
> +                "1skdjh9q4m438wwl8hwx3jc5hg22dmi5pwm3vd2yksxw6ny67rd7"))))
> +    (arguments
> +     (substitute-keyword-arguments (package-arguments qtsvg-5)
> +       ((#:tests? _ #f) #f) ; TODO: pass 2 fail test
> +       ((#:phases phases)
> +        `(modify-phases ,phases
> +           (add-before 'check 'set-display
> +             (lambda _
> +               ;; Make Qt render "offscreen", required for tests.
> +               (setenv "QT_QPA_PLATFORM" "offscreen")
> +               (setenv "DISPLAY" ":1")
> +               (system "Xvfb +extension GLX :1 &")))
> +           (delete 'check)               ;move after the install phase
> +           (add-after 'install 'check
> +             (assoc-ref %standard-phases 'check))
> +           (add-before 'check 'prepare-for-tests
> +             (lambda* (#:key outputs #:allow-other-keys)
> +               (setenv "QML2_IMPORT_PATH"
> +                       (string-append (assoc-ref outputs "out")
> +                                      "/lib/qt5/qml:"
> +                                      (getenv "QML2_IMPORT_PATH")))
> +               (setenv "QT_PLUGIN_PATH"
> +                       (string-append (assoc-ref outputs "out")
> +                                      "/lib/qt6/plugins:"
> +                                      (getenv "QT_PLUGIN_PATH")))))))))

The above caught my eye; is the 'qt6' here a typo?  I presume so, since
the package is a Qt 5 one.  Probably the second setenv can be dropped
without any effect.

-- 
Thanks,
Maxim