guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#27554] Add dirvish and dependencies


From: Ludovic Courtès
Subject: [bug#27554] Add dirvish and dependencies
Date: Sun, 02 Jul 2017 17:20:37 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux)

Hi Chris!

Christopher Allan Webber <address@hidden> skribis:

> From 60a448f1daf37927155577dabaf1c090f9404bee Mon Sep 17 00:00:00 2001
> From: Christopher Allan Webber <address@hidden>
> Date: Sat, 1 Jul 2017 20:45:04 -0500
> Subject: [PATCH 1/3] gnu: Add perl-libtime-parsedate.
>
> * gnu/packages/perl.scm (perl-libtime-parsedate): New variable.

[...]

> +    (arguments
> +     ;; Output when running tests:
> +     ;;   t/metdate.t ... skipped: It seems localtime() does not honor
> +     ;;   $ENV{TZ} when set in the test script.
> +     ;; Seemingly related:
> +     ;;   
> https://stackoverflow.com/questions/19956693/timeparsedate-install-fail
> +     ;;   https://rt.cpan.org/Public/Bug/Display.html?id=90367
> +     `(#:tests? #f))

Perhaps if we add a dependency on tzdata and set TZDIR, as is done for
‘duplicity’ for instance, the tests would run?

Anyway this probably shouldn’t block the whole series!

> From f475a133812a4d62e32a90caa26f41bb242f8a37 Mon Sep 17 00:00:00 2001
> From: Christopher Allan Webber <address@hidden>
> Date: Sat, 1 Jul 2017 20:46:00 -0500
> Subject: [PATCH 2/3] gnu: Add perl-libtime-period.
>
> * gnu/packages/perl.scm (perl-libtime-period): New variable.

[...]

> +    (license (package-license perl))))

Please use ‘license:perl-license’ here.

> From 01b0c93222658f74d5049f1666d383efacf4a724 Mon Sep 17 00:00:00 2001
> From: Christopher Allan Webber <address@hidden>
> Date: Sun, 20 Nov 2016 10:36:46 -0600
> Subject: [PATCH 3/3] gnu: Add dirvish.
>
> * gnu/packages/backup.scm (dirvish): New variable.

[...]

> +    (home-page "http://dirvish.org/";)
> +    (license (license:fsf-free "file://COPYING")))) ; Open Software License 
> 2.0

You can make it:

   (license:fsf-free "file://COPYING"
                     "Open Software License 2.0")

OK with these changes, thank you!

Ludo’.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]