guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#27643] [PATCH] gnu: Add simplescreenrecorder.


From: Arun Isaac
Subject: [bug#27643] [PATCH] gnu: Add simplescreenrecorder.
Date: Tue, 11 Jul 2017 01:45:19 +0530

Thanks for the patch!

> +    (inputs `(("pkg-config" ,pkg-config)

pkg-config should be a native input.

> +              ("qt" ,qt-4) ; README.md: using Qt 5 causes some stability 
> issues
> +              ("ffmpeg" ,ffmpeg)
> +              ("alsa-lib" ,alsa-lib)
> +              ("pulseaudio" ,pulseaudio)
> +              ("jack" ,jack-1)
> +              ("glu" ,glu)
> +              ("libx11" ,libx11)
> +              ("libxfixes" ,libxfixes)
> +              ("libxext" ,libxext)

The package builds successfully without libx11, libxfixes and libxext
included as inputs. Are you sure they are needed? Could you check again?

> +              ("libxi" ,libxi)))

Also, could you sort all the inputs in alphabetical order, just for the
aesthetic appeal? :-)

> +    ;; Using HTTPS causes part of the page displayed improperly.
> +    (home-page "http://www.maartenbaert.be/simplescreenrecorder/";)

We'll go with the HTTP URL for now. But, do report this issue upstream
as well.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]