guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#27650] [PATCH] gnu: services: admin: Add tailon.


From: Christopher Baines
Subject: [bug#27650] [PATCH] gnu: services: admin: Add tailon.
Date: Sun, 16 Jul 2017 16:51:49 +0100

On Wed, 12 Jul 2017 14:13:25 +0200
address@hidden (Ludovic Courtès) wrote:

> Hi Christopher,
> 
> Christopher Baines <address@hidden> skribis:
> 
> > * gnu/services/admin.scm
> >   (<tailon-configuration>, <tailon-configuration-file>): New record
> > types. (tailon-configuration-files-string,
> > tailon-shepherd-service): New procedures.
> >   (%tailon-accounts, tailon-service-type: New variables.
> > * doc/guix.text (Monitoring Services: Document the Tailon service.  
> 
> Neat.  Maybe a service we could take advantage of on our build farm
> machines?

Thanks for your review, I'll send an updated patch with the texinfo
improvements, and the path/file/directory naming changes.

> > +(define-gexp-compiler (tailon-configuration-file-compiler
> > +                       (file <tailon-configuration-file>) system
> > target)  
> 
> That’s a good idea.  :-)

I'm glad you think so. This pattern should make either using the
provided record type, or something else very easy, as there are no
special cases in the service code.

> Bonus points if you write a system test that checks that at least the
> Web server shows up on port 8080.

I've had a go at this, I'll send a separate patch. It doesn't pass for
me yet, and I'm not sure how to work out what is going on inside the
test system, does anyone have any tips for writing and debugging system
tests in general?

Attachment: pgpq8kZMrgtxN.pgp
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]