[bug#27691] Tabs and patches names

[Ludovic Courtès]

Hi Oleg,

Oleg Pykhalov <address@hidden> skribis:

>>From 39f61dbcc0b7b09a325536149eee6c69c7526b4e Mon Sep 17 00:00:00 2001
> From: Oleg Pykhalov <address@hidden>
> Date: Fri, 14 Jul 2017 15:34:33 +0300
> Subject: [PATCH] gnu: Add tome4.
>
> * gnu/packages/games.scm (tome4): New variable.

Please add the patches to gnu/local.mk.

> +                      (substitute* "tome4.desktop"
> +                        (("Exec=/usr")
> +                         (string-append "Exec="
> +                                        (assoc-ref outputs "out")
> +                                        "/usr")))

Is it needed?  I would expect the ‘patch-dot-desktop-files’ to do the
right thing.

> +    (synopsis "Roguelike RPG")
> +    (description "Tales of Maj’Eyal (ToME) is a free, open source roguelike

Please remove “free, open source”: that’s always the case in Guix.  :-)

> diff --git a/gnu/packages/patches/tome4-add-desktop-file.patch 
> b/gnu/packages/patches/tome4-add-desktop-file.patch
> new file mode 100644
> index 000000000..80fd82478
> --- /dev/null
> +++ b/gnu/packages/patches/tome4-add-desktop-file.patch
> @@ -0,0 +1,27 @@
> +From b8e207e145938f7a0f23d1c5107d532ebb9de720 Mon Sep 17 00:00:00 2001
> +From: Oleg Pykhalov <address@hidden>
> +Date: Fri, 14 Jul 2017 11:19:37 +0300
> +Subject: [PATCH] Add desktop file.
> +
> +---
> + tome4.desktop | 8 ++++++++
> + 1 file changed, 8 insertions(+)
> + create mode 100644 tome4.desktop
> +
> +diff --git a/tome4.desktop b/tome4.desktop
> +new file mode 100644
> +index 000000000..c5d67f0cf
> +--- /dev/null
> ++++ b/tome4.desktop
> +@@ -0,0 +1,8 @@
> ++[Desktop Entry]
> ++Name=ToME4
> ++Comment=An open-source, single-player, role-playing roguelike game set in 
> the world of Eyal.
> ++Exec=/usr/bin/tome4
> ++Icon=tome4.png
> ++Terminal=false
> ++Type=Application
> ++Categories=Game;RolePlaying;

For each patch, could you write a line explaining whether they are
upstream patches, to simplify future updates?

Also, please remove “open-source” from the comment.  (BTW I recommend
<https://www.gnu.org/philosophy/open-source-misses-the-point.html>.)

> @@ -0,0 +1,23 @@
> +From f10d89912989e0f071855ab2c20d62b318d313fc Mon Sep 17 00:00:00 2001
> +From: Oleg Pykhalov <address@hidden>
> +Date: Fri, 14 Jul 2017 11:17:26 +0300
> +Subject: [PATCH] Add shell wrapper for launching.
> +
> +---
> + tome4 | 4 ++++
> + 1 file changed, 4 insertions(+)
> + create mode 100644 tome4
> +
> +diff --git a/tome4 b/tome4
> +new file mode 100644
> +index 000000000..2b623e467
> +--- /dev/null
> ++++ b/tome4
> +@@ -0,0 +1,4 @@
> ++#!/usr/bin/sh
> ++cd "/opt/tome4"
> ++./t-engine &
> ++exit

If this is not an upstream patch, I would find it nicer to create the
wrapper directly from the build phase, and with the right directory name
instead of “/opt”.

Could you send an updated patch?

Thank you!

Ludo’.