guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#27865] [PATCH 2/3] pull: Fetch source code from Git.


From: Mathieu Othacehe
Subject: [bug#27865] [PATCH 2/3] pull: Fetch source code from Git.
Date: Sun, 30 Jul 2017 15:15:21 +0200
User-agent: mu4e 0.9.18; emacs 25.2.1

Hi Ludo,

Nice job ! Error code handling in git is really a welcome addition too
:)

> +    ((? integer? error)                           ;old Guile-Git
> +     (leave (G_ "Git error ~a~%") error))
> +    ((? git-error? error)                         ;new Guile-Git
> +     (leave (G_ "Git error: ~a~%") (git-error-message error)))))

If an old Guile-Git (without error support) is used git-error? and
git-error-message won't be available anyway, so it is really necessary
to test for an integer ?

I'll use the same piece of code in Cuirass soon.

Thanks,

Mathieu





reply via email to

[Prev in Thread] Current Thread [Next in Thread]