[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#29480] [PATCH] gnu: Add xautolock.
From: |
Ludovic Courtès |
Subject: |
[bug#29480] [PATCH] gnu: Add xautolock. |
Date: |
Sat, 02 Dec 2017 11:02:06 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) |
Hi,
Mike Gerwitz <address@hidden> skribis:
> On Thu, Nov 30, 2017 at 15:56:11 +0100, Ludovic Courtès wrote:
>> I took the liberty to make the changes below:
>
> Ah, thanks!
>
>> diff --git a/gnu/packages/xdisorg.scm b/gnu/packages/xdisorg.scm
>> - (zero? (system* "xmkmf"))
>> + (invoke "xmkmf")
>
> Okay, that makes much more sense. I was wondering if `zero?' had some
> special meaning in that context.
‘zero?’ returns a Boolean and in this case it was ignored.
> gnu/packages/xfig.scm:93 uses it in a non-tail position as well. I
> looked at the history for the file but it was always like that;
> perhaps that should be `invoke' too?
I guess we should! I’ve made the change and will push soonish.
Thanks,
Ludo’.