guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#30380] gnu: Add dolphin-emulator.


From: Thompson, David
Subject: [bug#30380] gnu: Add dolphin-emulator.
Date: Wed, 7 Feb 2018 15:53:03 -0500

Hello,

On Wed, Feb 7, 2018 at 3:43 PM, Björn Höfling
<address@hidden> wrote:
> On Wed, 7 Feb 2018 11:58:02 -0500
> "Thompson, David" <address@hidden> wrote:
>
>> Here a couple of patches that add the Dolphin emulator.  I used a Git
>> snapshot because the project goes *years* between releasing official
>> source tarballs while at the same time directing users to use binaries
>> built from the latest commit in their Git repo, so I think packaging
>> the Git source aligns best with what a Dolphin user would expect.
>>
>> - Dave
>
> Hi Dave,
>
> I haven't done a full review, here are some things I noticed:
>
> * License is GPLv2+, not only v2.
> * dolphin/Data/Sys/GC/font_*.bin: Licensed under ASL2.0.
> * The homepage states this package is only available for x86_64.
>   If that is true, add a line like this to your package:
>   (supported-systems '("x86_64-linux"))
> * dolphin/Installer/dxredist/ contains (Windows) binaries. Remove with
>   a snippet.
> * Remove dolphin/Externals in a snippet. Or at least those that you
>   have added as dependencies.
> * There are binaries in the distribution:
>   dolphin/Data/Sys/GC/dsp_coef.bin and dsp_rom.bin
>   The commit message says something like "based off of observed
> effects on the virtual machine", but still this is binaray. Or is there
>   some way of building this from commented assembly? Here is the full
>   commit message:
>   
> https://github.com/dolphin-emu/dolphin/commit/e3531d17d700339828d7bab192c66fba5fcbac86
>
> * Finally, doesn't this encourage people to use non-free software, i.e.
>   the original manufacturers game discs? Or is there any free software
>   implementation running on this emulator?
>
> Björn

Nevermind. I am dropping this patch set.

Sorry,

- Dave





reply via email to

[Prev in Thread] Current Thread [Next in Thread]