[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#30333: [PATCH] gnu: Add emacs-scratch-el.
From: |
Oleg Pykhalov |
Subject: |
bug#30333: [PATCH] gnu: Add emacs-scratch-el. |
Date: |
Wed, 14 Feb 2018 16:00:29 +0300 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) |
Marius Bakke <address@hidden> writes:
> Oleg Pykhalov <address@hidden> writes:
>
>> * gnu/packages/emacs.scm (emacs-scratch-el): New public variable.
>
> [...]
>
>> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
>> index 9523f14da..69d18b060 100644
>> --- a/gnu/packages/emacs.scm
>> +++ b/gnu/packages/emacs.scm
>> @@ -6940,3 +6940,41 @@ navigation with the grails mode.")
>> @code{org-tree-slide-mode} to enter the slideshow mode, and then @kbd{C->}
>> and
>> @kbd{C-<} to jump to the next and previous slide.")
>> (license license:gpl3+))))
>> +
>> +(define-public emacs-scratch-el
>> + (let ((commit "2cdf2b841ce7a0987093f65b0cc431947549f897")
>> + (revision "1"))
>> + (package
>> + (name "emacs-scratch-el")
>> + (version (string-append "1.2" revision "."
>> + (string-take commit 7)))
>
> You can use (git-version "1.2" revision commit) here.
OK.
> (by the way, where does 1.2 come from?)
https://github.com/ieure/scratch-el/blob/master/scratch.el#L4
>> + (source (origin
>> + (method git-fetch)
>> + (uri (git-reference
>> + (url "https://github.com/ieure/scratch-el.git")
>> + (commit commit)))
>> + (file-name (string-append name "-" version "-checkout"))
>
> Similarly, prefer (git-file-name ...).
OK.
>> + (sha256
>> + (base32
>> + "0wscsndynjmnliajqaz28r1ww81j8wh84zwaaswx51abhwgl0idf"))))
>> + (build-system emacs-build-system)
>> + (native-inputs
>> + `(("texinfo" ,texinfo)))
>> + (arguments
>> + '(#:phases
>> + (modify-phases %standard-phases
>> + (add-after 'install 'install-doc
>> + (lambda* (#:key outputs #:allow-other-keys)
>> + (unless (invoke "makeinfo" "scratch.texi")
>> + (error "makeinfo failed"))
>> + (install-file "scratch.info"
>> + (string-append (assoc-ref outputs "out")
>> + "/share/info")))))))
>
> (install-file ...) has an unspecified return value, so return #t here.
OK.
>> + (home-page "https://github.com/ieure/scratch-el/")
>> + (synopsis "Create scratch buffers with the same mode current buffer")
>
> s/same mode/same mode as/
OK.
> Other than that LGTM.
Pushed as ac07b94ab53fb13bb56ea876a5143985e6dfaf11
I'll close the bug report.
Thanks,
Oleg.
signature.asc
Description: PGP signature