[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#29483] [PATCH] services: Add openntpd service.
From: |
Efraim Flashner |
Subject: |
[bug#29483] [PATCH] services: Add openntpd service. |
Date: |
Sun, 4 Mar 2018 20:02:43 +0200 |
User-agent: |
Mutt/1.9.3 (2018-01-21) |
On Fri, Mar 02, 2018 at 05:46:30PM +0100, Ludovic Courtès wrote:
> Hello,
>
> Efraim Flashner <address@hidden> skribis:
>
> > On Mon, Feb 05, 2018 at 04:26:52PM +0100, Ludovic Courtès wrote:
> >> Heya Efraim,
> >>
> >> > +(define openntpd-shepherd-service
> >> > + (match-lambda
> >> > + (($ <openntpd-configuration> openntpd openntpd-listen-on
> >> > + openntpd-query-from openntpd-sensor openntpd-server
> >> > + openntpd-servers openntpd-constraint-from
> >> > + openntpd-constraints-from allow-large-adjustment?)
> >>
> >> This is error prone (you could be matching the wrong fields), could you
> >> change that to ‘match-record’?
> >>
> >
> > I think this is the only thing left over.
>
> To be clear, the switch from ‘match-lambda’ to ‘match-record’ should be
> entirely mechanical. The above snippet would become:
>
> (define (openntpd-shepherd-service config)
> (match-record config <openntpd-configuration>
> (openntpd openntpd-listen-on
> openntpd-query-from openntpd-sensor openntpd-server
> openntpd-servers openntpd-constraint-from
> openntpd-constraints-from allow-large-adjustment?)
> …))
>
> That’s all I was suggesting. The body of that procedure can remain
> unchanged.
>
> Does that make sense?
>
Yes, that does make sense. Switching helped me find that I mistakenly
used openntpd-<var> when it should've just been <var>, so I've fixed
that. I've also added a default value field, like the ones that were
recently added for the SQL services, and I tested that it worked with
(service openntpd-service-type) in my test config.
--
Efraim Flashner <address@hidden> אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
0001-services-Add-openntpd-service.patch
Description: Text document
signature.asc
Description: PGP signature