[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#30701] [PATCH 1/4] services: Rework the PostgreSQL config file to u
From: |
Clément Lassieur |
Subject: |
[bug#30701] [PATCH 1/4] services: Rework the PostgreSQL config file to use a record type. |
Date: |
Mon, 05 Mar 2018 01:32:10 +0100 |
User-agent: |
mu4e 1.0; emacs 25.3.1 |
Hi Christopher,
Christopher Baines <address@hidden> writes:
> For the default config file representation. This makes it possible to more
> easily change the configuration file, and have dynamic content. In particular,
> I'm looking at adding a pid file location to the config file.
>
> * gnu/services/databases.scm (<postgresql-config-file>): New record type.
> (%default-postgres-config): Remove this, it's been replaced by the
> configuration file.
> (<postgresql-configuration>): Alter the default for the config file field.
> (postgresql-service): Alter the default value for the config-file parameter.
> ---
> gnu/services/databases.scm | 86
> +++++++++++++++++++++++++++++++++++-----------
> 1 file changed, 66 insertions(+), 20 deletions(-)
Thank you for this work!
> +(define-gexp-compiler (postgresql-config-file-compiler
> + (file <postgresql-config-file>) system target)
> + (match file
> + (($ <postgresql-config-file> log-destination hba-file
> + ident-file extra-config)
> + (define (quote string)
> + (if string
> + (list "'" string "'")
> + (list)))
I don't think it's a good thing to hide one of the most important lisp
functions :-).
- [bug#30701] [PATCH 3/4] tests: databases: Add a system test for PostgreSQL., (continued)
[bug#30701] [PATCH 4/4] services: databases: Add postgresql-configuration record exports., Christopher Baines, 2018/03/04
[bug#30701] [PATCH 2/4] services: Use a external pid file for PostgreSQL., Christopher Baines, 2018/03/04
[bug#30701] [PATCH 1/4] services: Rework the PostgreSQL config file to use a record type.,
Clément Lassieur <=
[bug#30701] [PATCH 1/3] services: Rework the PostgreSQL config file to use a record type., Christopher Baines, 2018/03/05
[bug#30701] [PATCH 3/3] services: databases: Add postgresql-configuration record exports., Christopher Baines, 2018/03/05
[bug#30701] [PATCH 1/3] services: Rework the PostgreSQL config file to use a record type., Christopher Baines, 2018/03/05