[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#30948] [PATCH core-updates] guix: Reap finished child processes in
From: |
Carlo Zancanaro |
Subject: |
[bug#30948] [PATCH core-updates] guix: Reap finished child processes in build containers. |
Date: |
Mon, 26 Mar 2018 22:16:34 +1100 |
User-agent: |
mu4e 1.0; emacs 25.3.1 |
When working on the Shepherd, I found that in the build containers
processes don't get reaped by pid 1. See
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=30637#29. This
caused (and will cause) the Shepherd's tests to fail on some
systems.
Our guile-builder script should handle SIGCHLD and then use
waitpid to reap the child processes. Here's my attempt at a patch
to do that.
I haven't been able to build anything with it because the computer
I'm currently on is laughably slow. If someone else can check that
you can still build with it I'd really appreciate it.
From 7c66818570a139fc4e7b11de34d07c76ebdc6bac Mon Sep 17 00:00:00 2001
From: Carlo Zancanaro <address@hidden>
Date: Mon, 26 Mar 2018 22:08:26 +1100
Subject: [PATCH] guix: Reap finished child processes in build containers.
* guix/derivations (build-expression->derivation)[prologue]: Handle SIGCHLD
and reap child processes when they finish.
---
guix/derivations.scm | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/guix/derivations.scm b/guix/derivations.scm
index da686e89e..80787e99e 100644
--- a/guix/derivations.scm
+++ b/guix/derivations.scm
@@ -1180,6 +1180,17 @@ ALLOWED-REFERENCES, DISALLOWED-REFERENCES, LOCAL-BUILD?,
and SUBSTITUTABLE?."
(filter module-form? exp))
(_ `(,exp)))
+ ;; The root process in the build container should reap
+ ;; processes that die, so handle SIGCHLD.
+ (sigaction SIGCHLD
+ (lambda ()
+ (let loop ()
+ (match (waitpid WAIT_ANY WNOHANG)
+ ((0 . _) #f)
+ ((pid . _) (loop))
+ (_ #f))))
+ SA_NOCLDSTOP)
+
(define %output (getenv "out"))
(define %outputs
(map (lambda (o)
--
2.16.2
signature.asc
Description: PGP signature
- [bug#30948] [PATCH core-updates] guix: Reap finished child processes in build containers.,
Carlo Zancanaro <=