[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#30970] Add package definition for screen message
From: |
Marius Bakke |
Subject: |
[bug#30970] Add package definition for screen message |
Date: |
Wed, 28 Mar 2018 21:46:07 +0200 |
User-agent: |
Notmuch/0.26 (https://notmuchmail.org) Emacs/25.3.1 (x86_64-pc-linux-gnu) |
Ton <address@hidden> writes:
> Here is the package definition for screen message. A simple program to fill
> your screen with text input either as an argument to the program or input
> during execution.
>
> Built and tested on GuixSD Linux merlin 4.15.8-gnu #1 SMP 1 x86_64 GNU/Linux.
>
> It passes guix lint without errors.
>
> It builds 5 times deterministicly.
>
> Guix size says "total: 568.0 MiB"
Thank you for this patch, and for testing reproducibility and linting!
I think it can go to 'xdisorg.scm' instead of a separate module. Can
you also add a copyright line for yourself? Pseudonyms are fine.
Overall the patch LGTM, some nitpicks:
> From c6ddc41853ff22acb3923b221b8530a057875253 Mon Sep 17 00:00:00 2001
> From: Tonton <address@hidden>
> Date: Wed, 28 Mar 2018 15:45:07 +0200
> Subject: [PATCH] Add package definition screen message
>
> Built and tested on GuixSD Linux merlin 4.15.8-gnu #1 SMP 1 x86_64 GNU/Linux.
>
> It passes guix lint without errors.
>
> It builds 5 times deterministicly.
>
> Guix size says "total: 568.0 MiB"
Please see 'git log' for commit message conventions.
[...]
> +(define-public screen-message
> + (package
> + (name "screen-message")
> + (version "0.25")
> + (source (origin
> + (method url-fetch)
> + (uri
> + (string-append
> +
> "http://www.joachim-breitner.de/archive/screen-message/screen-message-"
> + version ".tar.gz"))
Use HTTPS here, and on the home page.
> + (sha256
> + (base32
> + "1lw955qq5pq010lzmaf32ylj2iprgsri9ih4hx672c3f794ilab0"))))
> + (build-system gnu-build-system)
> + (inputs `(("gtk3" ,gtk+)
> + ("gdk" ,gdk-pixbuf)
> + ("pango" ,pango)))
> + (native-inputs `(("pkgconfig" ,pkg-config)))
^^^
"pkg-config"
> + (arguments
> + `(#:make-flags (list (string-append "execgamesdir=" %output "/bin"))))
> + (synopsis "Prints messages on your screen")
s/Prints/Print/
> + (description "If you just want to disply a word or a short, possilby
^^^
Typo:
> +multi-line, text as large and as quickly as possible on your screen,
> +then “screen-message” is the right tool for you.")
Use @code{screen-message} instead of quotes.
However I would rewrite this to something along the lines of
"@code{screen-message} is a tool for displaying text on your screen. It
will make the text as large as possible and display it with black color
on a white background."
This was shamelessly adapted from Debians description, feel free to
expand on it: <https://packages.debian.org/sid/sm>.
Can you send an updated patch please? Thanks in advance!
signature.asc
Description: PGP signature