guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#31007: [PATCH] gnu: Add xapers.


From: Eric Bavier
Subject: bug#31007: [PATCH] gnu: Add xapers.
Date: Wed, 4 Apr 2018 09:39:15 -0500

On Wed, 04 Apr 2018 02:42:34 -0400
Adam Massmann <address@hidden> wrote:

> Hi Eric,
> 
> Thank you very much for reviewing the patch and providing the
> feedback. I was able to make the fixes you pointed out and attached the
> updated patches below. I also fixed some mistakes on alphabetical order
> I had missed.

Great, thank you!

> 
> While digging more into the missing tests for pybtex I realized that the
> problems with tests were actually an error on my part - I apologize! I
> misinterpreted some output as suggesting that tests were missing, when
> in reality I was letting Guix send the wrong test target to
> python-build. This is fixed now and the tests work.

Awesome.

> 
> Thanks again for your time spent on the contribution; it's a big help
> particularly for someone new to this like me. 
> 

No problem; just paying it forward.

I've pushed these three patches in 

c2b2f0c86691f6d76f528b6366c866b8f3665c3c
2514fc1d69ec556c9c18d2463a892f43fa175557
f50bad80a93eabab598f3d6d621818b67cefb70b

with minor changes.  Thank you for the contribution; hope to see some
more from you! :)

`~Eric

Attachment: pgpqhLi8tvJHX.pgp
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]