[bug#31121] [PATCH 3/3] gnu: Add osc.

[Marius Bakke]

Tomáš Čech <address@hidden> writes:

>  * gnu/packages/build-tools.scm (osc): New variable.

[...]

> +(define-public osc
> +  (package
> +    (name "osc")
      ^
Indentation off here too.

> +    (version "0.162.1")
> +    (source
> +     (origin
> +       (method url-fetch)
         ^
And here.

> +       (uri (string-append "https://github.com/openSUSE/"; name
> +                           "/archive/" version ".tar.gz"))
> +       (file-name (string-append name "-" version ".tar.gz"))
> +       (sha256
> +        (base32 "0b4kpm96ns4smqyfjysbk2p78d36x44xprpna8zz85q1y5xn57aj"))))
> +    (build-system python-build-system)
> +    (arguments
> +     `(#:python ,python-2 ;; Module is python2 only.
                             ^
Only one semicolon for margin comments.

> +       #:phases
> +       (modify-phases %standard-phases
> +         (add-after 'install 'fix-filename-and-remove-unused
> +           (lambda* (#:key outputs #:allow-other-keys)
> +             (let ((bin (string-append (assoc-ref outputs "out") "/bin/")))
> +               ;; Main osc tool is renamed in spec file, not setup.py, let's
> +               ;; do that too.
> +               (rename-file
> +                (string-append bin "osc-wrapper.py")
> +                (string-append bin "osc"))
> +               ;; Remove unused and broken script.
> +               (delete-file (string-append bin "osc_hotshot.py"))
> +             #t))))))
> +    (inputs
> +     `(("python2-m2crypto" ,python2-m2crypto)
> +       ("python2-pycurl" ,python2-pycurl)
> +       ("python2-urlgrabber" ,python2-urlgrabber)))
> +    (home-page "https://github.com/openSUSE/osc";)
> +    (synopsis "Open Build Service command line tool")
> +    (description "@command{osc} is command line interface to Open Build
                                   ^^^                       ^^^
                                   "is a"                   "to the"
Other than that LGTM.

> +Service.  It allows you to checkout, commit, perform reviews etc.  The vast
> +majority of the OBS functionality is available via commands and the rest can
> +be reached via direct API calls.")
> +    (license license:gpl2+)))
> -- 
> 2.16.3

signature.asc
Description: PGP signature