[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#32053] [PATCH 2/2] gnu: Add quaternion.
From: |
Arun Isaac |
Subject: |
[bug#32053] [PATCH 2/2] gnu: Add quaternion. |
Date: |
Tue, 10 Jul 2018 10:53:27 +0530 |
>> + (inputs
>> + `(("libqmatrixclient-source" ,(package-source libqmatrixclient))
>> + ("qt" ,qt)))
>> + (arguments
>> + `(#:tests? #f ; No tests
>> + #:phases
>> + (modify-phases %standard-phases
>> + (add-after 'unpack 'unpack-libqmatrixclient
>> + (lambda* (#:key inputs #:allow-other-keys)
>> + (invoke "tar" "-C" "lib" "-xvf"
>> + (assoc-ref inputs "libqmatrixclient-source")
>> + "--strip-components=1"))))))
>
> That doesn’t sound great. :-)
>
> Could we arrange to have it use an externally-built libqtmatrixclient.so?
> Perhaps that’ll involve modifying the CMake/Qt/whatever build files?
Yes, it isn't great. But I did that because that's the build process
upstream recommends. :-( I will explore alternatives and get back to
you.
>> + (synopsis "Qt5 desktop client for the Matrix protocol")
>
> What about: “Graphical client for the Matrix instant messaging protocol”?
>
>> + (description "Quaternion is a Qt5 desktop client for the Matrix
>> protocol.
>
> s/protocol/instant messaging protocol/
>
> It’s all about giving enough context so that people know what kind of
> matrix we’re talking about. ;-)
Sure, I'll make these synopsis and description changes (for both
libqmatrixclient and quaternion). In my opinion, upstream calling their
protocol "Matrix" is a somewhat poor choice. The word "Matrix" is easily
confused with many other things.