[bug#33080] [PATCH] gnu: Add inferno.

[Ludovic Courtès]

Hi Diego,

Sorry for the late reply.

Diego Nicola Barbato <address@hidden> skribis:

> This patch adds inferno as discussed here:
> https://lists.gnu.org/archive/html/guix-devel/2018-10/msg00031.html

In that thread we discussed the font issue, and I’m unsure if it was
resolved:

  <https://lists.gnu.org/archive/html/guix-devel/2018-10/msg00265.html>

Is everything “known good” with this version of the patch?

> From c97b28e97a210cc31e34c08bc1abdc8bd74114fa Mon Sep 17 00:00:00 2001
> From: Diego Nicola Barbato <address@hidden>
> Date: Wed, 17 Oct 2018 23:07:40 +0200
> Subject: [PATCH] gnu: Add inferno.
>
> * gnu/packages/inferno.scm: New file.
> * gnu/local.mk (GNU_SYSTEM_MODULES): Register it.

Overall it LGTM!  Minor suggestions here:

> +         #:phases
> +         (let* ((bash (assoc-ref %build-inputs "bash"))
> +                (objtype ,@(match (%current-system)
> +                             ((or "armhf-linux" "aarch64-linux")
> +                              `("arm"))
> +                             (_
> +                              `("386"))))
> +                (out (assoc-ref %outputs "out"))
> +                (root (string-append out "/share/inferno"))
> +                (root/bindir (string-append root "/Linux/"
> +                                            objtype "/bin"))
> +                (bindir (string-append out "/bin"))
> +                (infwm-script (string-append bindir "/infwm")))
> +           `(,(assoc 'set-paths %standard-phases)
> +             (unpack . ,(lambda* (#:key source #:allow-other-keys)

For consistency, I would very much prefer if we could use
‘modify-phases’ here, which is what is used throughout gnu/packages.
If that’s fine with you, could you update the patch?

> +      (synopsis
> +       "Compact operating system for building cross-platform distributed 
> systems")

Maybe shorten to “Operating system for building distributed systems”?

Thanks!

Ludo’.