[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#35127] [PATCH] Add meritous.
From: |
Ricardo Wurmus |
Subject: |
[bug#35127] [PATCH] Add meritous. |
Date: |
Wed, 03 Apr 2019 22:07:21 +0200 |
User-agent: |
mu4e 1.0; emacs 26.1 |
Hi Nicolas,
> + (add-after 'unpack 'fix-sdl-path
> + ;; XXX: For some reason, `sdl-config' reports stand-alone SDL
> + ;; directory, not SDL-union provided as an input to the package.
> + ;; We force the latter with "--prefix=" option.
> + (lambda* (#:key inputs #:allow-other-keys)
> + (substitute* "Makefile"
> + (("sdl-config" command)
> + (string-append command " --prefix=" (assoc-ref inputs
> "sdl"))))
> + #t))
Hmm, weird. Do you know why this happens? Is this something we can fix
in sdl-union?
> + (add-after 'unpack 'fix
> + ;; XXX: Songs are removed due to licensing issues. However, the
> + ;; game tries to load them, and, since it cannot find them,
> + ;; crashes. Users cannot add them back, the store being
> read-only,
> + ;; so we turn off background music altogether.
Oh :(
Where are the songs removed? Should they be removed in a snippet?
> + (lambda _
> + (substitute* "src/audio.c"
> + (("PlayBackgroundMusic\\(new_track\\);" all)
> + (string-append "// " all))))))))
Please end with #T.
> + (native-inputs
> + `(("intltool" ,intltool)))
> + (inputs
> + `(("sdl" ,(sdl-union (list sdl sdl-image sdl-mixer)))
> + ("zlib" ,zlib)))
> + ;; Original home page <http://asceai.net/meritous/> has stalled.
I don’t think “stalled” is the right term. I think you can remove this
comment. The gitlab page is fine as a home page.
> + (description "Far below the surface of the planet is a secret. A place
> of
> +limitless power.
How about “a secret place of limitless power”? (“is a secret” sounds
odd to me.)
> +Meritous is a action-adventure game with simple controls but a challenge to
> +find a balance of power verses recovery time during real-time
> battles.
Should be “versus”.
--
Ricardo