[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#35155] [PATCH] build-system/cargo: refactor phases to successfully
From: |
Ivan Petkov |
Subject: |
[bug#35155] [PATCH] build-system/cargo: refactor phases to successfully build |
Date: |
Sat, 6 Apr 2019 09:12:37 -0700 |
Hi Danny,
> On Apr 6, 2019, at 3:41 AM, Danny Milosavljevic <address@hidden> wrote:
>
>> + (generate-checksums rsrc "/dev/null")
>
> Hmm, is the "package" entry in the final file ".cargo-checksums.json" useless?
> Can it be left off completely?
Yes, it appears that cargo expects there to be a “package” hash definition in
.cargo-checksum.json, but it doesn’t verify the contents (it only checks if
they’ve
changed since the last time it updated its Cargo.lock file).
Since this procedure is directly used when building rust-1.20, I didn’t want to
change its definition and get blocked on bootstrapping all of rustc again.
Though I agree, we should update the procedure at some point.
—Ivan