[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#35110] [PATCH v2 1/2] Add (guix build-system linux-module).
From: |
Ludovic Courtès |
Subject: |
[bug#35110] [PATCH v2 1/2] Add (guix build-system linux-module). |
Date: |
Thu, 11 Apr 2019 12:50:42 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
Hi Danny,
Danny Milosavljevic <address@hidden> skribis:
> * guix/build/linux-module-build-system.scm: New file.
> * guix/build-system/linux-module.scm: New file.
> * Makefile.am (MODULES): Add them.
Awesome!
> +(define* (configure #:key inputs #:allow-other-keys)
> + #t)
> +; (let ((source (string-append (assoc-ref inputs "linux")
> +; "/Module.symvers")))
> +; (if (file-exists? source)
> +; (install-file source out-lib-build))
> +; #t))
I think you should either remove this comment or add an explanation
and/or a TODO.
Could you also add a note in doc/guix.texi under “Build Systems”?
Otherwise LGTM, thank you!
Ludo’.
- [bug#35110] [PATCH 2/3] gnu: Add vhba-module-linux-libre., (continued)
[bug#35110] [PATCH 1/3] gnu: Add make-linux-module., Ludovic Courtès, 2019/04/03
[bug#35110] [PATCH v2 0/2] Add support for loadable modules., Danny Milosavljevic, 2019/04/05