[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#64711] [PATCH 00/45] Fix builds and skip failing tests for the Hurd
From: |
Ludovic Courtès |
Subject: |
[bug#64711] [PATCH 00/45] Fix builds and skip failing tests for the Hurd. |
Date: |
Tue, 18 Jul 2023 22:13:28 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) |
Hello!
Great work!
A general comment: these changes to test suites were made based on
feedback from non-chrooted builds, whose outcome is influenced by system
state such as running translators. Until we have chroot builds, I think
we should be cautious and not invest too much time.
Janneke Nieuwenhuizen <janneke@gnu.org> skribis:
> * gnu/packages/base.scm (coreutils)[arguments]: When building natively on the
> Hurd, remove "test/df/unreadable.sh" and "test-perror2" from #:make-flags's
> XFAIL_TESTS as they now pass. Move failing script tests from XFAIL_TESTS to
> 'remove-tests' phase. In phase 'remove-tests' rewrite substitute* to skip
> tests instead of removing them. Add hanging and failing tests.
[...]
> + '((substitute*
> + ;; These tests hang
> + '("tests/cp/sparse-to-pipe.sh"
> + "tests/split/fail.sh"
> + ;; These tests error
> + "tests/dd/nocache.sh"
> + ;; These tests fail
> + "tests/cp/sparse.sh"
> + "tests/cp/special-f.sh"
> + "tests/dd/bytes.sh"
> + "tests/dd/stats.sh"
> + "tests/ls/dangle.sh"
> + "tests/ls/follow-slink.sh"
> + "tests/ls/hyperlink.sh"
> + "tests/ls/infloop.sh"
> + "tests/ls/inode.sh"
> + "tests/ls/selinux-segfault.sh"
> + "tests/misc/env-S.pl"
> + "tests/misc/factor-parallel.sh"
> + "tests/misc/ls-misc.pl"
> + "tests/misc/nice.sh"
> + "tests/misc/pwd-long.sh"
> + "tests/misc/shred-passes.sh"
> + "tests/misc/stat-slash.sh"
> + "tests/rm/fail-eperm.xpl"
> + "tests/split/filter.sh")
> + (("^#!.*" all)
> + (string-append all "exit 77;\n")))
For example, I wonder how reliable this long list is. Some of these
tests may fiddle with /proc, /etc/fstab, and other things not under
control, which means some might suddenly pass for some reason. So I
wonder if we should just #:tests? #f in this case.
Thoughts?
(With other, higher-level test suites with a couple of failures, it’s
probably still a good idea to skip individual tests instead of the whole
test suite.)
Ludo’.
- [bug#64711] [PATCH 00/45] Fix builds and skip failing tests for the Hurd., Janneke Nieuwenhuizen, 2023/07/18
- [bug#64711] [PATCH 05/43] Revert "gnu: sed: Skip failing test on GNU/Hurd.", Janneke Nieuwenhuizen, 2023/07/18
- [bug#64711] [PATCH 01/43] Revert "gnu: libunistring: Fix make check for the Hurd.", Janneke Nieuwenhuizen, 2023/07/18
- [bug#64711] [PATCH 02/43] gnu: guile: Skip hanging and failing pipe tests on the Hurd., Janneke Nieuwenhuizen, 2023/07/18
- [bug#64711] [PATCH 04/43] gnu: grep: Update hanging and failing tests on the Hurd., Janneke Nieuwenhuizen, 2023/07/18
- [bug#64711] [PATCH 03/43] gnu: coreutils: Skip hanging and failing test on the Hurd., Janneke Nieuwenhuizen, 2023/07/18
- [bug#64711] [PATCH 00/45] Fix builds and skip failing tests for the Hurd.,
Ludovic Courtès <=
- [bug#64711] [PATCH 06/43] gnu: findutils: Move test-strerror_r from XFAIL to skip on the Hurd., Janneke Nieuwenhuizen, 2023/07/18
- [bug#64711] [PATCH 07/43] gnu: diffutils: Remove test-perror2 from XFAIL_TESTS on the Hurd., Janneke Nieuwenhuizen, 2023/07/18
- [bug#64711] [PATCH 09/43] gnu: m4: Skip gnulib stack-overflow tests for the Hurd., Janneke Nieuwenhuizen, 2023/07/18
- [bug#64711] [PATCH 14/43] gnu: libbsd: Skip failing test on the Hurd., Janneke Nieuwenhuizen, 2023/07/18
- [bug#64711] [PATCH 15/43] gnu: c-ares: Skip failing tests on the Hurd., Janneke Nieuwenhuizen, 2023/07/18
- [bug#64711] [PATCH 13/43] gnu: elfutils: Skip failing tests on the Hurd., Janneke Nieuwenhuizen, 2023/07/18
- [bug#64711] [PATCH 08/43] gnu: gettext-minimal: Remove XFAIL_TESTS for the Hurd., Janneke Nieuwenhuizen, 2023/07/18
- [bug#64711] [PATCH 10/43] gnu: openssl: Build fix for the Hurd., Janneke Nieuwenhuizen, 2023/07/18