[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#68789] [PATCH 0/2] gnu: Add python-pyjanitor.
From: |
Troy Figiel |
Subject: |
[bug#68789] [PATCH 0/2] gnu: Add python-pyjanitor. |
Date: |
Mon, 29 Jan 2024 18:18:57 +0100 |
Hi Oleg,
Thanks for the check!
On 2024-01-29 15:26, Sharlatan Hellseher wrote:
> One note - you introduced a module cycle which was not before
> astronomy->python-science->astronomy. If the requirement of
> python-astropy is soft let's silent it for now.
Removing the python-astropy dependency should be fine for python-unyt. I
agree that avoiding module cycles would be better. If I recall
correctly, Astropy was only used in tests, because it has a similar
submodule dealing with physical units.
The build was successful and the cycle did not show up in the linter.
How did you find it? Did you happen to notice it when you saw the imports?
Best wishes,
Troy
OpenPGP_0xC67C9181B3893FB0.asc
Description: OpenPGP public key
OpenPGP_signature.asc
Description: OpenPGP digital signature
- [bug#68789] [PATCH 0/2] gnu: Add python-pyjanitor., Troy Figiel, 2024/01/28
- [bug#68789] [PATCH v2 0/2] gnu: Add python-pyjanitor., Troy Figiel, 2024/01/29
- [bug#68789] [PATCH 1/2] gnu: Add python-unyt., Troy Figiel, 2024/01/29
- [bug#68789] [PATCH 2/2] gnu: Add python-pyjanitor., Troy Figiel, 2024/01/29
- bug#68789: [PATCH 0/2] gnu: Add python-pyjanitor., Sharlatan Hellseher, 2024/01/29