[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#69343] [PATCH v2 00/12] Simplify bootloader data structures and pro
From: |
Lilah Tascheter |
Subject: |
[bug#69343] [PATCH v2 00/12] Simplify bootloader data structures and procedures |
Date: |
Fri, 8 Mar 2024 02:11:56 -0600 |
hey!
this is really useful!! love having access to generation numbers alongside
boot params, and the terminology fixing's great too :)
noticed a few problems - took the liberty to fix them in this v2 patch series:
* (gnu system boot) was missing a few imports that it needs to work.
* (gnu system boot) requires the procedure system-linux-image-file-name, which
is defined in (gnu system). I moved it over to (gnu system boot).
* generation->boot-alternative in (guix scripts system) had typos in variables
resulting in them not being used.
* commit messages didn't have relevant gnu changelog info.
* one of those commit messages had a wholeass log that's Way too much extraneous
information and just got in the way when trying to look at the actual patch
this v2 passes all relevant unit tests, but could still definately use some
verification that the modified paths function properly before I'd say this is
ready to be merged. notably, system reconfigure and ssh managed machine
reconfigure should be verified, but then it should be good?
thanks ya!!
- lilah
Felix Lechner (12):
Fix bug where the extra menu entries for a bootloader were shown
twice.
Move <boot-parameters> record to a separate file.
Also move boot-parameters->menu-entry.
Rename seconds->string procedure to epoch->date-string.
Move epoch->date-string to gnu/system/boot.scm and use it elsewhere.
Offer a uniform decorated-boot-label and use it.
Rename boot-parameters to boot-alternatives when appropriate.
Rename two remote variables confusingly named 'generations'.
Give a separate name to a commonly used expression.
Simplify profile->boot-alternatives.
Split generation->boot-parameters out of profile->boot-alternatives.
Encapsulate <boot-parameters> to retain generation, system-path and
epoch.
gnu/machine/ssh.scm | 74 ++++----
gnu/system.scm | 264 +---------------------------
gnu/system/boot.scm | 354 ++++++++++++++++++++++++++++++++++++++
guix/scripts/system.scm | 71 ++++----
tests/boot-parameters.scm | 1 +
5 files changed, 430 insertions(+), 334 deletions(-)
create mode 100644 gnu/system/boot.scm
base-commit: 9038a46751c5090246e64b63ff752064833c435b
--
2.41.0
- [bug#69343] [PATCH v2 00/12] Simplify bootloader data structures and procedures,
Lilah Tascheter <=
- [bug#69343] [PATCH v2 01/12] Fix bug where the extra menu entries for a bootloader were shown twice., Lilah Tascheter, 2024/03/08
- [bug#69343] [PATCH v2 09/12] Give a separate name to a commonly used expression., Lilah Tascheter, 2024/03/08
- [bug#69343] [PATCH v2 06/12] Offer a uniform decorated-boot-label and use it., Lilah Tascheter, 2024/03/08
- [bug#69343] [PATCH v2 05/12] Move epoch->date-string to gnu/system/boot.scm and use it elsewhere., Lilah Tascheter, 2024/03/08
- [bug#69343] [PATCH v2 03/12] Also move boot-parameters->menu-entry., Lilah Tascheter, 2024/03/08
- [bug#69343] [PATCH v2 08/12] Rename two remote variables confusingly named 'generations'., Lilah Tascheter, 2024/03/08
- [bug#69343] [PATCH v2 02/12] Move <boot-parameters> record to a separate file., Lilah Tascheter, 2024/03/08
- [bug#69343] [PATCH v2 10/12] Simplify profile->boot-alternatives., Lilah Tascheter, 2024/03/08
- [bug#69343] [PATCH v2 04/12] Rename seconds->string procedure to epoch->date-string., Lilah Tascheter, 2024/03/08
- [bug#69343] [PATCH v2 12/12] Encapsulate <boot-parameters> to retain generation, system-path and epoch., Lilah Tascheter, 2024/03/08