guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#69743] [PATCH] update grimshot package definition


From: Jack Hill
Subject: [bug#69743] [PATCH] update grimshot package definition
Date: Tue, 12 Mar 2024 09:29:18 -0400 (EDT)
User-agent: Alpine 2.21 (DEB 202 2017-01-01)

On Tue, 12 Mar 2024, Ignas Lapėnas wrote:

Issue: https://issues.guix.gnu.org/69667

Grimshot was dropped from sway.
https://github.com/swaywm/sway/issues/7405

The contrib was moved to:
https://github.com/OctopusET/sway-contrib

Package definition updated accordingly.

Change-Id: I9ed9cdf7ce10fe878b4f2b931791ed22a63ff99a
---
gnu/packages/wm.scm | 60 +++++++++++++++++++++++++--------------------
1 file changed, 33 insertions(+), 27 deletions(-)

diff --git a/gnu/packages/wm.scm b/gnu/packages/wm.scm
index edbb3096b8..eeaee0cb68 100644
--- a/gnu/packages/wm.scm
+++ b/gnu/packages/wm.scm
@@ -3524,46 +3524,52 @@ (define-public avizo

I haven't had a chance to test on a system yet, but thanks for preparing this, reading through it it looks good.

+                   (add-after 'patch-script-dependencies 'build-man-page
+                     (lambda _
+                       (with-input-from-file "grimshot.1.scd"
+                         (lambda _
+                           (with-output-to-file "grimshot.1"
+                             (lambda _
+                               (invoke "scdoc"))))))))))

I'm happy to see this improvement of building the manpage from source.

    (native-inputs (list scdoc))
    (inputs (list coreutils
-                  grim
                  jq
                  libnotify
                  slurp
                  sway
                  wl-clipboard))
+    (propagated-inputs (list grim))

For my curiosity, what's the benefit of propagating grim? It looks like the full bath is also being substituted in the script?

Thanks!
Jack

reply via email to

[Prev in Thread] Current Thread [Next in Thread]