help-smalltalk
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Help-smalltalk] Re: Trouble to build gnu-smalltlak-2.3.4 (test suite fa


From: Paolo Bonzini
Subject: [Help-smalltalk] Re: Trouble to build gnu-smalltlak-2.3.4 (test suite failed)
Date: Tue, 29 May 2007 11:08:08 +0200
User-agent: Thunderbird 2.0.0.0 (Macintosh/20070326)


For geometry.st, the problem is that sqrt is computed with a slightly different precision on x86_64, apparently. I can fix it by using a Pythagorean triple (i.e. making sure the sqrt is integer). It's not a big deal, I guess you can patch out the failing test (both the .st and .ok files); Thomas, you'll probably have the same problem on Debian.

Here's a patch.

Paolo
* looking for address@hidden/smalltalk--stable--2.3--patch-54 to compare with
* comparing to address@hidden/smalltalk--stable--2.3--patch-54
M  tests/geometry.ok
M  tests/geometry.st

* modified files

--- orig/tests/geometry.ok
+++ mod/tests/geometry.ok
@@ -36,10 +36,10 @@ Execution begins...
 returned value is Point new "<0>"
 
 Execution begins...
-'A dist: B = '136.0147050873544
+'A dist: B = '104.0
 'C dotProduct: D = '20000
 'C grid: D = 'address@hidden
-'C normal = 'address@hidden
+'E normal * 5 = 'address@hidden
 'C truncatedGrid: D = 'address@hidden
 'address@hidden transpose = 'address@hidden
 returned value is Point new "<0>"


--- orig/tests/geometry.st
+++ mod/tests/geometry.st
@@ -112,19 +112,20 @@ myAreasOutside: a
 
 "point functions"
 
-| A B C D |
+| A B C D E |
   A := address@hidden
-  B := address@hidden
+  B := address@hidden
   C := address@hidden
   D := address@hidden
+  E := address@hidden
   'A dist: B = ' print.
   (A dist: B) printNl.
   'C dotProduct: D = ' print.
   (C dotProduct: D) printNl.
   'C grid: D = ' print.
   (C grid: D) printNl.
-  'C normal = ' print.
-  (C normal) printNl.
+  'E normal * 5 = ' print.
+  (E normal * 5) rounded printNl.
   'C truncatedGrid: D = ' print.
   (C truncatedGrid: D) printNl.
   'address@hidden transpose = ' print.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]