Re: [Help-smalltalk] [please review] CharacterArray>>#%

[Stephen Compall]

On Mon, 2007-06-25 at 15:40 +0200, Paolo Bonzini wrote:
> I've just added CharacterArray>>#% to 2.3 and 3.0.

I think this is great.  I'll be changing my #bindWith:* sends to it as
soon as I update again.

>  from: aPoint to: endPoint
>      ^'%1.%2 %3.%4'
> -     bindWith: aPoint y printString
> -     with: (aPoint x - 1) printString
> -     with: endPoint y printString
> -     with: (endPoint x - 1) printString
> +     % { aPoint y printString.  (aPoint x - 1) printString.
> +         endPoint y printString.  (endPoint x - 1) printString }
>  !

I don't think these #'printString's are necessary, not that that has
anything to do with it....

>  setInitialSize
> @@ -3687,8 +3687,7 @@ initialize: parentWidget
>      label := ''.
>      exists := false.
>      primitive := '%1.w%2'
> -     bindWith: self parent container
> -     with: (self asOop printString: 36).
> +     % { self parent container. self asOop printString: 36 }).

Extra paren, I think.

>      ^(directory at: directory size) isPathSeparator
>       ifTrue: [ directory, fileName ]
> -     ifFalse: [ '%1%2%3'
> -         bindWith: directory
> -         with: self pathSeparator
> -         with: fileName ]
> +     ifFalse: [ directory, self pathSeparatorString, fileName ]

{directory. self pathSeparatorString. fileName} join :)

-- 
;;; Stephen Compall ** http://scompall.nocandysw.com/blog **
"Peta" is Greek for fifth; a petabyte is 10 to the fifth power, as
well as fifth in line after kilo, mega, giga, and tera.
  -- Lee Gomes, performing every Wednesday in his tech column
     "Portals" on page B1 of The Wall Street Journal

signature.asc
Description: This is a digitally signed message part