[Help-smalltalk] Re: Swazoo 2.2 beta with fast file upload

[Paolo Bonzini]

Paolo Bonzini wrote:
> > Please help testing it. It is available here:
> >
> > - Squeak: http://www.squeaksource.com/Swazoo/Swazoo-2.2.beta1.mcz
>
> For portability, you should look for subtractions without a space on 
> either side.  I found a few in the new code for POST handling (all of 
> them something-1 or something-2).
>
> The class definition for CompositeResourceTest is missing.

Other nits:

- this, I really don't like:

watchdogSites
    self sites do:
        [:each |
        each isServing
           ifTrue: [(each isKindOf: AIDASite) ifTrue: [each 
setLastTimeAliveTimestamp]]]

why not just add Site>>#watchdogEvent (as empty method) and override it 
in AIDASite?  I'll do this for GNU Smalltalk.

- #watchdogOther is not defined.

- I had sent to Janko a changeset fixing a race condition.  I have a 
small difference in two methods that probably were not merged correctly. 
 Here they are:

    HTTPConnection >> nextPutError: aResponse
        aResponse informConnectionClose.
        aResponse writeTo: self stream.

    HTTPConnection >> nextPutResponse: aMessage toRequest: aRequest
        aMessage writeTo: self stream inResponseTo: aRequest

because #writeTo: and #writeTo:inResponseTo: already do a #closeResponse.


I didn't find any other problem in my review of the code in 2.1 vs. 
2.2beta.  I am struggling with the usual non-portability of SwazooBuffer 
but everything else seems to work.

Paolo