[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Help-smalltalk] gst-package "empty filenames are invalid"
From: |
Paolo Bonzini |
Subject: |
Re: [Help-smalltalk] gst-package "empty filenames are invalid" |
Date: |
Sat, 09 Aug 2008 14:28:11 +0200 |
User-agent: |
Thunderbird 2.0.0.16 (Macintosh/20080707) |
Tony Garnock-Jones wrote:
From a fresh git checkout, on OS X 10.5.4,
- make works
- make install gets part-way through before failing.
It looks like there's some code duplication in Directory class >>
append:to: and FilePath class >> append:to:. The FilePath version is
newer, but behaves differently in the case of an empty fileName
parameter. Should the redundancy be removed? Should they be made to
behave the same? Am I looking in completely the wrong place?
You're right -- I'm now preparing 3.0c and have already fixed it. The
fix (and a couple of makefile tweaks needed for `make distcheck' to
pass) is already in my repository though I have not yet pushed it to
savannah. I don't know when I'll announce the release though; I want to
do 3.0.4 too and it takes a lot of time to run all the tests, prepare
the announcements, clean up the house :-) and so on.
Directory class>>#append:to: is obsolete indeed, and left for backwards
compatibility.
Thanks!
Paolo
diff --git a/scripts/Package.st b/scripts/Package.st
index 41c92c0..5af172d 100644
--- a/scripts/Package.st
+++ b/scripts/Package.st
@@ -334,12 +334,13 @@ Command subclass: PkgDist [
ifFalse: [ aPackage allDistFiles ].
dirs := files collect: [ :file | File pathFor: file ].
- dirs := dirs asSet asOrderedCollection.
+ dirs := dirs asSet remove: '' ifAbsent: [ ]; asSortedCollection.
baseDir := self installDir.
aPackage relativeDirectory isNil ifFalse: [
baseDir := baseDir / aPackage relativeDirectory ].
+ baseDir emitMkdir.
dirs do: [ :dir | (baseDir / dir) emitMkdir ].
files do: [ :file || srcFile destName |