[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Help-smalltalk] [PATCH] gst-profile
From: |
Paolo Bonzini |
Subject: |
Re: [Help-smalltalk] [PATCH] gst-profile |
Date: |
Fri, 27 Feb 2009 08:35:58 +0100 |
> 1, scripts/Profile.st is not installed by default, gst-profile can not find
> it.
Thanks
> 2, I highly recommending making no-separate-blocks the default.
Ok.
> 3, this need to be done to avoid potential endless recursion:
Ops, I forgot to push a patch.
> 4, yes, if there is fileIn inside the profiling block (which is guarantied
> with gst-profile) the 2 things I observed before still happen:
> * Some methods get negative cost. I believe this is caused by somewhere
> inside fileIn the byteCounter is reset to 0.
It's in _gst_execute_statements, I fixed it in the same patch I've not pushed.
> * I still observed some crashes; and they disappeared if I manually invoke
> the profiler to avoid fileIns. The crashes are non-intuitive yet
> deterministic; same program will always crash the same way; and some
> superficial change to the program can make the crash to disappear or appear
> or move to another place. One workaround is to change fileIn to always
> push/pop profiler around it but that feels ugly too.
Do you have a simple example (I can use delta to minimize it, send it
offlist if there are privacy problems of any kind).
Paolo