help-smalltalk
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Help-smalltalk] [patch] Remove duplicate category output in RBForma

From: Paolo Bonzini
Subject: Re: [Help-smalltalk] [patch] Remove duplicate category output in RBFormatter>>#acceptMethodNode:
Date: Tue, 27 Oct 2009 20:55:09 +0100
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.4pre) Gecko/20091014 Fedora/3.0-2.8.b4.fc11 Lightning/1.0pre Thunderbird/3.0b4 
On 10/27/2009 06:53 PM, Lee Duhem wrote:

Hi,

This patch fix the following problem:

st>  (Array lookupSelector: #print) methodFormattedSourceString
'print [
        "Print a represention of the receiver on the Transcript (stdout the GUI
         is not active)"

        <category: ''printing''>
        <category: ''printing''>
        Transcript show: self printString
     ]'


This unfortunately breaks gst-convert.
The right fix would be more complicated and it would involve basically 1) creating a new parse node type, 2) extracting STCompiler>>#compileAttribute: to RBMethodNode and making it create the new parse node type, 3) rewriting RBMethodNode>>#category and #category: to use the new parse node type as well.
Gwen is doing work on the RBParser, maybe it's best to wait for him to finish that. 

Thanks anyway!  Can you file a bug report on smalltalk.gnu.org?

Paolo
reply via email to
[Prev in Thread] Current Thread [Next in Thread]