[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Help-smalltalk] [PATCH] Fix multiple binds to the same port
From: |
Holger Hans Peter Freyther |
Subject: |
Re: [Help-smalltalk] [PATCH] Fix multiple binds to the same port |
Date: |
Wed, 19 Jan 2011 20:06:52 +0100 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.13) Gecko/20101209 Fedora/3.1.7-0.35.b3pre.fc14 Lightning/1.0b2 Thunderbird/3.1.7 |
On 01/19/2011 06:13 PM, Paolo Bonzini wrote:
>
> Ok, now I can reproduce it, but it seems a bug to me. This is a
> self-contained C reproducer:
The autobinding to a port? Yeah it was a bit surprising but then started to
make sense.
>
> You're right. Using errno is thread-unsafe since Smalltalk threads share the
> errno and you could have an interrupt at exactly "that" time.
>
> I'll have to fix it.
Ah, you are right. The two options i see is to either just raise an exception
without knowing the specific issue, or as you said put syscall and errno into
a critical section (eeek...)