help-smalltalk
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Help-smalltalk] [PATCH 3/3] cint: Fail the VMpr_CFuncDescriptor_cal


From: Holger Hans Peter Freyther
Subject: Re: [Help-smalltalk] [PATCH 3/3] cint: Fail the VMpr_CFuncDescriptor_call primitive with wrong args
Date: Sat, 05 Feb 2011 17:06:31 +0100
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.13) Gecko/20101209 Fedora/3.1.7-0.35.b3pre.fc14 Lightning/1.0b2 Thunderbird/3.1.7

On 02/05/2011 04:29 PM, Paolo Bonzini wrote:

> I'll make it XFAIL for now.  For 3.3 we can change the PrimitiveFailed to
> invoke a Smalltalk implementation of the type checks and raise a proper
> exception.

It fails because we don't ignore the stderr output... e.g. this will make the
test case pass. I will put that into another patch... so you can put this
before the cint patch.

diff --git a/tests/local.at b/tests/local.at
index 49f9111..7dedf2c 100755
--- a/tests/local.at
+++ b/tests/local.at
@@ -64,7 +64,7 @@ m4_define([AT_OPTIONAL_PACKAGE_TEST], [
     case $ret in
       2) exit 77 ;;
       0|1) exit $ret ;;
-    esac], [], [], [ignore])
+    esac], [], [], [ignore], [ignore])
   AT_CLEANUP
 ])




reply via email to

[Prev in Thread] Current Thread [Next in Thread]