help-smalltalk
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Help-smalltalk] [PATCH 4/5] svnprintf: modernize and improve its build


From: Stefano Lattarini
Subject: [Help-smalltalk] [PATCH 4/5] svnprintf: modernize and improve its build system
Date: Mon, 20 Aug 2012 21:56:23 +0200

* snvprintf/Makefile.am (DIST_SUBDIRS): Don't explicitly define
to $(SUBDIRS), that's the default anyway.
(MAINTAINERCLEANFILES): Don't clean the various Autotools-generated
files, that goes against the GNU coding standards, which explicitly
say "... more generally, 'make maintainer-clean' should not delete
anything that needs to exist in order to run 'configure' and then
begin to build the program".
(aclocaldir): Remove definition; it's not used anyway, since the
file 'snprintfv.m4' is not installed.
(dist_noinst_DATA): Drop as useless, since the only file listed
in there ('snprintfv.m4') is automatically distributed, being
'm4_included'd in the generated aclocal.m4.
(nodist_noinst_HEADERS): Drop as useless, since the only file
listed in there ('config.h') is automatically generated anyway
by ./configure.
Also remove some redundant comments and blank lines.
* snvprintf/snvprintf/Makefile.am (AWK): Remove, it's never used.
(MAINTAINERCLEANFILES): Don't clean the Automake-generated
Makefile.in files, that goes against the GNU coding standards.

Signed-off-by: Stefano Lattarini <address@hidden>
---
 ChangeLog                       | 24 ++++++++++++++++++++++++
 snprintfv/Makefile.am           | 19 -------------------
 snprintfv/snprintfv/Makefile.am |  2 --
 3 files changed, 24 insertions(+), 21 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 426b934..fdeec4b 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,29 @@
 2012-08-20  Stefano Lattarini  <address@hidden>
 
+       svnprintf: modernize and improve its build system
+
+       * snvprintf/Makefile.am (DIST_SUBDIRS): Don't explicitly define
+       to $(SUBDIRS), that's the default anyway.
+       (MAINTAINERCLEANFILES): Don't clean the various Autotools-generated
+       files, that goes against the GNU coding standards, which explicitly
+       say "... more generally, 'make maintainer-clean' should not delete
+       anything that needs to exist in order to run 'configure' and then
+       begin to build the program".
+       (aclocaldir): Remove definition; it's not used anyway, since the
+       file 'snprintfv.m4' is not installed.
+       (dist_noinst_DATA): Drop as useless, since the only file listed
+       in there ('snprintfv.m4') is automatically distributed, being
+       'm4_included'd in the generated aclocal.m4.
+       (nodist_noinst_HEADERS): Drop as useless, since the only file
+       listed in there ('config.h') is automatically generated anyway
+       by ./configure.
+       Also remove some redundant comments and blank lines.
+       * snvprintf/snvprintf/Makefile.am (AWK): Remove, it's never used.
+       (MAINTAINERCLEANFILES): Don't clean the Automake-generated
+       Makefile.in files, that goes against the GNU coding standards.
+
+2012-08-20  Stefano Lattarini  <address@hidden>
+
        build: don't use files with non-standard extensions in _SOURCES
 
        While they are still perfectly supported in mainline Automake, they
diff --git a/snprintfv/Makefile.am b/snprintfv/Makefile.am
index 430ff7a..75c10b1 100644
--- a/snprintfv/Makefile.am
+++ b/snprintfv/Makefile.am
@@ -24,30 +24,11 @@
 ## uses the libopts library from AutoGen, you may include it under
 ## the same distribution terms used by the libopts library.
 
-## Code:
-
 ACLOCAL_AMFLAGS                = -I ../build-aux
 AUTOMAKE_OPTIONS       = gnits
 
-## BEGIN GNU SMALLTALK LOCAL
 dist-hook:
        rm -rf $(distdir)/doc $(distdir)/tests
 
 SUBDIRS                        = snprintfv
-## SUBDIRS              = snprintfv doc tests
-## END GNU SMALLTALK LOCAL
-
-DIST_SUBDIRS           = $(SUBDIRS)
-
-MAINTAINERCLEANFILES   = Makefile.in aclocal.m4 configure config.h.in \
-                         stamp-h.in
-
-nodist_noinst_HEADERS   = config.h
-
-aclocaldir              = $(datadir)/aclocal
-dist_noinst_DATA        = snprintfv.m4
-
 dist_noinst_SCRIPTS     = gendoc.awk genproto commit
-
-# Makefile.am ends here
-
diff --git a/snprintfv/snprintfv/Makefile.am b/snprintfv/snprintfv/Makefile.am
index e78596a..aa72113 100644
--- a/snprintfv/snprintfv/Makefile.am
+++ b/snprintfv/snprintfv/Makefile.am
@@ -29,9 +29,7 @@
 AUTOMAKE_OPTIONS       = gnits
 
 DISTCLEANFILES          = compat.h compat.stamp
-MAINTAINERCLEANFILES   = Makefile.in
 
-AWK                    = gawk
 GENPROTO               = $(top_srcdir)/genproto
 GENPROTO_FLAGS         = $(top_srcdir)/gendoc.awk
 GENPROTO_ENVIRONMENT   = FORMAT=SNV_GNUC_PRINTF
-- 
1.7.12.rc0.129.g61b472e




reply via email to

[Prev in Thread] Current Thread [Next in Thread]