Re: [Help-smalltalk] [PATCH] build: support and require Automake-NG

[Paolo Bonzini]

Il 21/08/2012 11:22, Stefano Lattarini ha scritto:

Cool, let's look at it one by one.

> * configure.ac (AC_PREREQ): Require Autoconf version >= 2.65,
> since that is the minimal version supported by Automake-NG.

This is good.

> (AC_SUBST): Define AM_VARTYPOS_WHITELIST to "LIBFFI_EXECUTABLE_LDFLAGS
> RELOC_LDFLAGS".  This is required because Automake-NG is stricter than
> mainline Automake in its make runtime checks on possible typos in
> variables like 'foo_SOURCES' and 'bar_LDADD', and that was causing a
> spurious failure in the GNU Smalltalk build system.

Can Automake-NG instead whitelist all-uppercase variables?  Also, this
is different from all other configuration mechanisms; it would be nicer
to have it as an Automake-provided AM_* macro, or a Makefile.am definition.

> * Makefile.am (AUTOMAKE_OPTIONS): Add the 'ng' option, to ensure that
> mainstream Automake is not used by mistake when bootstrapping.  Also,
> bump the required Automake version from '1.11.1' to '1.12a', which is
> the latest (and still development-only) version of Automake-NG at the
> moment of writing.  Drop the 'dist-xz' option, that is not supported
> anymore.  The same effect is now obtained ...
> (AM_DIST_FORMATS): ... defining this to "gzip xz".

Can you instead provide the  backwards-compatible format with a
deprecation period?  And perhaps add support for AM_DIST_FORMATS in
mainline Automake?

> * .gitignore: Ignore all the '.am/' directories everywhere; it's
> used internally by some Automake-NG generated rules.
> * build-aux/.gitignore: Ignore the 'am-ng/' directory; it's used by
> Automake-NG to install makefile fragments used by its generated
> Makefiles.

This is not a problem, of course.

Paolo