Re: [Help-smalltalk] [PATCH 4/5] svnprintf: modernize and improve its build system

[Stefano Lattarini]

On 08/21/2012 05:52 PM, Paolo Bonzini wrote:
> Il 20/08/2012 21:56, Stefano Lattarini ha scritto:
>> * snvprintf/Makefile.am (DIST_SUBDIRS): Don't explicitly define
>> to $(SUBDIRS), that's the default anyway.
>> (MAINTAINERCLEANFILES): Don't clean the various Autotools-generated
>> files, that goes against the GNU coding standards, which explicitly
>> say "... more generally, 'make maintainer-clean' should not delete
>> anything that needs to exist in order to run 'configure' and then
>> begin to build the program".
>> (aclocaldir): Remove definition; it's not used anyway, since the
>> file 'snprintfv.m4' is not installed.
>> (dist_noinst_DATA): Drop as useless, since the only file listed
>> in there ('snprintfv.m4') is automatically distributed, being
>> 'm4_included'd in the generated aclocal.m4.
>> (nodist_noinst_HEADERS): Drop as useless, since the only file
>> listed in there ('config.h') is automatically generated anyway
>> by ./configure.
>> Also remove some redundant comments and blank lines.
>> * snvprintf/snvprintf/Makefile.am (AWK): Remove, it's never used.
>> (MAINTAINERCLEANFILES): Don't clean the Automake-generated
>> Makefile.in files, that goes against the GNU coding standards.
> 
> What part of this is a cleanup, and what part is required?
> 
Should all be a cleanup (albeit INCLUDES was being AC_SUBST'd, it
was always empty AFAICS, so caused no real incompatibility; just
dead code).  Nothing in this change *should* be actually required
for the Automake-NG conversion.

Regards,
  Stefano