[Help-smalltalk] [PATCH 02/15] misc: Fix compiler warnings in libgst.

[Holger Hans Peter Freyther]

From: Holger Hans Peter Freyther <address@hidden>

The user of the get_attributes_array is working on the message OOP,
no need to get the message and not use it.

2013-02-24  Holger Hans Peter Freyther  <address@hidden>

        * libgst/dict.c: Remove ATTRIBUTE_HIDDEN from static methods.
        * libgst/comp.c: Remove unused variables in get_attributes_array.
        * libgst/save.c: Remove unused variable in make_oop_table_to_be_saved.
---
 libgst/ChangeLog |    6 ++++++
 libgst/comp.c    |    3 ---
 libgst/dict.c    |    6 ++----
 libgst/save.c    |    2 --
 4 files changed, 8 insertions(+), 9 deletions(-)

diff --git a/libgst/ChangeLog b/libgst/ChangeLog
index a88ec3b..e95a837 100644
--- a/libgst/ChangeLog
+++ b/libgst/ChangeLog
@@ -1,3 +1,9 @@
+2013-02-24  Holger Hans Peter Freyther  <address@hidden>
+
+       * libgst/dict.c: Remove ATTRIBUTE_HIDDEN from static methods.
+       * libgst/comp.c: Remove unused variables in get_attributes_array.
+       * libgst/save.c: Remove unused variable in make_oop_table_to_be_saved.
+
 2013-01-17  Gwenael Casaccio  <address@hidden>
 
        * libgst/sysdep/win32/timer.c: Correct the function signature.
diff --git a/libgst/comp.c b/libgst/comp.c
index 9d60cec..10330e1 100644
--- a/libgst/comp.c
+++ b/libgst/comp.c
@@ -2313,9 +2313,6 @@ get_attributes_array (tree_node attribute_list)
     {
       tree_node value = attribute_list->v_list.value;
       OOP messageOOP = value->v_const.val.oopVal;
-      gst_message message = (gst_message) OOP_TO_OBJ (messageOOP);
-      OOP selectorOOP = message->selector;
-
       attributes->data[i] = messageOOP;
     }
 
diff --git a/libgst/dict.c b/libgst/dict.c
index 542c42a..f4324b7 100644
--- a/libgst/dict.c
+++ b/libgst/dict.c
@@ -182,15 +182,13 @@ OOP _gst_processor_oop = NULL;
    dictionary instance that DICTIONARYOOP is pointing to with a new,
    larger dictionary, and returns this new dictionary (the object
    pointer, not the OOP).  */
-static gst_object grow_dictionary (OOP dictionaryOOP) 
-  ATTRIBUTE_HIDDEN;
+static gst_object grow_dictionary (OOP dictionaryOOP);
 
 /* Called when an IdentityDictionary becomes full, this routine
    replaces the IdentityDictionary instance that IDENTITYDICTIONARYOOP
    is pointing to with a new, larger dictionary, and returns this new
    dictionary (the object pointer, not the OOP).  */
-static gst_object grow_identity_dictionary (OOP identityDictionaryOOP) 
-  ATTRIBUTE_HIDDEN;
+static gst_object grow_identity_dictionary (OOP identityDictionaryOOP);
 
 /* Answer the number of slots that are in a dictionary of
    OLDNUMFIELDS items after growing it.  */
diff --git a/libgst/save.c b/libgst/save.c
index bf16368..be980a7 100644
--- a/libgst/save.c
+++ b/libgst/save.c
@@ -377,8 +377,6 @@ make_oop_table_to_be_saved (struct save_file_header *header)
     {
       if (IS_OOP_VALID_GC (oop))
        {
-         int numPointers = NUM_OOPS (oop->object);
-
           myOOPTable[i].flags = (oop->flags & ~F_RUNTIME) | F_OLD;
          myOOPTable[i].object = (gst_object) TO_INT (oop->object->objSize);
        }
-- 
1.7.10.4