[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Help-smalltalk] [PATCH 1/2] optimize FileStream>>#upTo: and FileStr
|
From: |
Holger Hans Peter Freyther |
|
Subject: |
Re: [Help-smalltalk] [PATCH 1/2] optimize FileStream>>#upTo: and FileStream>>#nextLine |
|
Date: |
Tue, 28 May 2013 20:12:37 +0200 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Sat, May 04, 2013 at 06:26:44PM +0200, Paolo Bonzini wrote:
> - | n resultStream result ch |
> + | start resultStream result ch |
n was unused so far?
> + [start := ptr.
> ptr := i + 1.
> - ch == ##(Character cr) ifTrue: [self peekFor:
> ##(Character nl)].
ah, I didn't know the ##(Character cr) trick. Nice that this is optimized.
The patch is looking fine.