[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Help-smalltalk] grow_dictionary
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Help-smalltalk] grow_dictionary |
|
Date: |
Fri, 12 Jul 2013 13:56:26 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130514 Thunderbird/17.0.6 |
Il 09/07/2013 03:45, Gwenaël Casaccio ha scritto:
> Hi,
>
> I think that grow_dictionary and grow_identity_dictionary could leak
> the newly allocated dictionary when calling _gst_swap_objects: it can
> tenure
> objects and in the worst case will do a GC (no_memory handler is called).
> The two objects should be GC protected in the grow*_method.
>
> Do you agree with my statements ?
I think you're right, but shouldn't they be protected in
_gst_swap_objects instead?
Paolo