[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Help-smalltalk] RBParser and negative numbers in arrays
|
From: |
Holger Hans Peter Freyther |
|
Subject: |
Re: [Help-smalltalk] RBParser and negative numbers in arrays |
|
Date: |
Fri, 16 Aug 2013 18:23:15 +0200 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Mon, Aug 12, 2013 at 08:57:05AM +0200, Holger Hans Peter Freyther wrote:
> On Sat, Aug 10, 2013 at 06:10:10PM +0200, Holger Hans Peter Freyther wrote:
> >
> > But RBParser parseExpression: '-3' parsed properly, it is the mix of
> > array literal and this. I would like to add a testLiteralArrayParsing
> > as well. But I can now parse the Grease tests and will look into updating
> > Grease to the latest version.
>
>
> I have applied the below changes. Interestingly parsing '-16r3' is working
> after your change, it does not go into the isNegative branch. This means
> that someone else is consuming the '-' before it is reaching scanNumberValue.
> I will try to step through this with the MiniDebugger.
parseNegatedNumber will be called after the '-' has been consumed. I am
running your change (and the changes I posted) through travis-ci and will
then push it to master.
kind regards
holger