[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Help-smalltalk] [PATCH] kernel/MappedColl.st: Fix variable name typ
|
From: |
Holger Hans Peter Freyther |
|
Subject: |
Re: [Help-smalltalk] [PATCH] kernel/MappedColl.st: Fix variable name typos |
|
Date: |
Fri, 13 Dec 2013 11:40:09 +0100 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Wed, Dec 11, 2013 at 10:19:11PM +0800, Lee Duhem wrote:
> Hi all,
Hi!
> The uninitialized temporary variable `newMap' has the value `nil', which
> obviously cannot understand message `select:'. According to the semantic
> of MappedCollection>>reject: or MappedCollection>>select:, the third
> occurrence of `newMap' in the above code should be `map', so this `newMap'
> may be a variable name typo. The attached patch could fix those variable
> name typos.
thank your very much! I have included your fix and created a testcase
for the invocation of >>#select: and >>#reject:. The commits are currently
running on travis-ci and will be pushed to master soon.
holger
PS:
> 2013-12-11 Lee Duhem <address@hidden>
GNU Changelog requires two spaces between "Duhem" and "<lee..."