help-smalltalk
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Help-smalltalk] [PATCH] Bytecode handling and printing refactoring

From: Gwenaël Casaccio
Subject: Re: [Help-smalltalk] [PATCH] Bytecode handling and printing refactoring
Date: Tue, 17 Dec 2013 11:25:16 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 
On 13/12/2013 16:08, Holger Hans Peter Freyther wrote:

On Fri, Dec 13, 2013 at 02:46:19PM +0100, Gwenaël Casaccio wrote:

Hi,

Hi!


I've removed the bytecode decoding, dispatching and printing methods from
CompiledCode class. Instead they are moved to they related
BytecodeDispatcher and ByteodePrinter classes. It makes the bytecode
handling code nicer, smaller, reusable and extendable.

good idea. But you seem to create copies of specialSelectorsNumArgs,
bytecodeInfoTable and specialSelectors. Why can't you remove that from
the CompildCode class?




Done.

Gwen

Attachment: 0001-Remove-the-bytecode-decoding-dispatching-and-printin.patch
Description: Text Data

reply via email to
[Prev in Thread] Current Thread [Next in Thread]