help-smalltalk
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Help-smalltalk] [PATCH 2/3] stinst: prepare for rewrite of #(...) p


From: Holger Hans Peter Freyther
Subject: Re: [Help-smalltalk] [PATCH 2/3] stinst: prepare for rewrite of #(...) parsing
Date: Tue, 7 Jan 2014 22:36:19 +0100
User-agent: Mutt/1.5.21 (2010-09-15)

On Tue, Jan 07, 2014 at 12:35:56PM +0100, Paolo Bonzini wrote:

> +     self size = aSequenceableCollection size 
...
> +     1 to: self size do: [:i |
...
> +        ^true


tabs vs. spaces?

> +    acceptLiteralArrayNode: aLiteralArrayNode [
> +     <category: 'visitor-double dispatching'>
> +     widget 
> +         highlightAs: #literal
> +         from: aLiteralNode start
> +         to: aLiteralNode start + 1.
> +        super acceptLiteralArrayNode: aLiteralArrayNode
> +     widget 
> +         highlightAs: #literal
> +         from: aLiteralNode stop
> +         to: aLiteralNode stop.

it references aLiteralNode. Probably wrong too.


> +    acceptLiteralArrayNode: aLiteralArrayNode [
> +     <category: 'visitor-double dispatching'>
> +     textBuffer applyTagByName: #literal startOffset: (aLiteralNode start - 
> 1) endOffset: aLiteralNode start.
> +       super acceptLiteralArrayNode: aLiteralArrayNode.
> +     textBuffer applyTagByName: #literal startOffset: (aLiteralNode stop - 
> 1) endOffset: aLiteralNode stop.
> +    ]
> +

You need to add Array to four of these variable names. Found by starting
up gst-browser as found in master. :)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]