[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Help-smalltalk] [PATCH] jit: Using BYTECODE_SIZE is not always the
|
From: |
Holger Hans Peter Freyther |
|
Subject: |
Re: [Help-smalltalk] [PATCH] jit: Using BYTECODE_SIZE is not always the right thing |
|
Date: |
Fri, 7 Feb 2014 19:00:58 +0100 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Fri, Feb 07, 2014 at 04:47:47PM +0100, Paolo Bonzini wrote:
> IIRC "IP - IP0" works as well, and it already appears in byte.def.
> Can you use that if it works?
Yes. it seems to work. May I push that change? In terms of AMD64
and JIT. The bundled version of GNU lightning doesn't compile for
AMD64 and after using the latest 1.x version it compiles but fails
quite quickly.
current = (method_entry *) xmalloc (MAX_BYTES_PER_BYTECODE * (size + 2));
is not enough for inlined primitives on AMD64. But even then I had
crashes on the travis-ci system. Do you remember if xlat.c ever
worked on AMD64?
holger