help-smalltalk
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Help-smalltalk] [PATCH 1/2] kernel: Make >>#new/>>#new: go through


From: Holger Hans Peter Freyther
Subject: Re: [Help-smalltalk] [PATCH 1/2] kernel: Make >>#new/>>#new: go through >>#initialize
Date: Sat, 26 Jul 2014 14:18:12 +0200
User-agent: Mutt/1.5.23 (2014-03-12)

On Thu, Jul 24, 2014 at 08:26:29PM +0200, Paolo Bonzini wrote:
> Il 24/07/2014 20:16, Holger Hans Peter Freyther ha scritto:
> > In Pharo it is common that new/new: will already go through an
> > initialize call. When porting code from and to Pharo one needs
> > to make sure that initialize is called and only called once or
> > idempotent. Align the code with Pharo.
> 
> I resisted doing this for several years, but I guess we should follow
> Pharo's leadership now.
> 
> However, I think you should squash the two patches.

Okay, I had verified that all tests pass when only applying the kernel(
and debugger) patch. 

Myclass class extend [
        new [
                ^super new initialize
        ]
]

Would now call initialize twice. I will squash the two patches and
write a "NEWS" items.

holger




reply via email to

[Prev in Thread] Current Thread [Next in Thread]