Re: [libmicrohttpd] a strange thing when send call returns -1 in send_cls()

[Christian Grothoff]

On 10/29/2014 08:42 AM, Taehwan Weon wrote:
> While testing our web-server (based on MHD 0.9.38), sometimes, I found
> heavy cpu load.
> It caused by infinite send_cls() calls because send call in send_cls()
> returned -1 with errno of 0.
> 
> I read and read again send() manual page, but there is no mention about the
> case that send() returns -1 with errno of 0.

I agree, that's why our logic doesn't quite expect that. But, nobody
said libc/kernel isn't allowed to have bugs ;-).  So my suggestion would
be this: I modify MHD to handle this (by closing the connection, don't
see what else we can do), and you should please take it up with CentOS,
asking them to fix that send() call. (What might be relevant these days:
is this using GNU libc or diet libc / ulibc?)

> My current environment is:
>      OS Kernel :  2.6.32-358.11.5.el6.x86_64 (CentOS)
>      MHD options:  MHD_USE_POLL_INTERNALLY | MHD_USE_THREAD_PER_CONNECTION|
> MHD_USE_DEBUG;
> 
> 
> Any help will be highly appreciated.

I've patched MHD in SVN 34391, please let us know if that helps (note
that IF the kernel does return -1 on send() with no errno, the new logic
should simply close the connection).

Happy hacking!

Christian

signature.asc
Description: OpenPGP digital signature