[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Lilypond-auto] Issue 3049 in lilypond: Parser outputs Lyric events
From: |
lilypond |
Subject: |
Re: [Lilypond-auto] Issue 3049 in lilypond: Parser outputs Lyric events for illegal note names |
Date: |
Thu, 27 Dec 2012 15:24:44 +0000 |
Updates:
Status: Fixed
Labels: -Patch-review Fixed_2_17_10
Comment #3 on issue 3049 by address@hidden: Parser outputs Lyric events for
illegal note names
http://code.google.com/p/lilypond/issues/detail?id=3049
Well, since this one is actually an embarrassment, and the fix (or rather
error condition) is straightforward and the error message identical to
similar conditions, I have pushed to staging as
commit 73d9385195d6ddcd355a89bf5ae6042d579c8333
Author: David Kastrup <address@hidden>
Date: Wed Dec 26 22:09:55 2012 +0100
Issue 3049: Parser outputs Lyric events for illegal note names
Well, after this patch this is what we still do (using void-music with
duration and post events seems even worse of a followup reaction,
silently dropping duration and post events not much better).
But additionally, an error is flagged. The complaint is "have to be
in Lyric mode for lyrics" which is accurate since in Lyric mode
arbitrary strings and markups may be accepted. At the point the error
is flagged, we don't necessarily have encountered an unquoted string,
so "bad note name" might be even more misleading. Before this issue
originated, the parser likely bombed out with "Unexpected STRING", and
frankly that's not really better than "have to be in Lyric mode".