lilypond-auto
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Lilypond-auto] Issue 3261 in lilypond: regtest 'incipit.ly' compres


From: lilypond
Subject: Re: [Lilypond-auto] Issue 3261 in lilypond: regtest 'incipit.ly' compressed
Date: Tue, 19 Mar 2013 05:58:36 +0000


Comment #1 on issue 3261 by address@hidden: regtest 'incipit.ly' compressed
http://code.google.com/p/lilypond/issues/detail?id=3261

Output does not look untypical/bad to me.  At any rate, I consider
http://code.google.com/p/lilypond/issues/detail?id=677
to be highly likely to be the cause of this change. However, the code in the regtest, namely
(let* ([...]
                (mm (ly:output-def-lookup layout 'mm))
                (indent (ly:output-def-lookup layout 'indent))
                (incipit-width (ly:output-def-lookup layout 'incipit-width))
                (scaled-incipit-width (if (number? incipit-width)
                                          (* incipit-width mm)
                                          (* indent 0.5))))
(ly:output-def-set-variable! layout 'indent (- indent scaled-incipit-width))
           (ly:output-def-set-variable! layout 'line-width indent)

looks fabulously inconsistent: probably it is compensating for the behavior fixed with the patch for issue 677, so we might get double scaling now. If that's the problem, we should likely check for similar incipit-related code in our codebase.

--
You received this message because this project is configured to send all issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings



reply via email to

[Prev in Thread] Current Thread [Next in Thread]