lilypond-auto
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Lilypond-auto] Issue 3439 in lilypond: Patch: Create a two-argument for


From: lilypond
Subject: [Lilypond-auto] Issue 3439 in lilypond: Patch: Create a two-argument form of define-event-class
Date: Fri, 05 Jul 2013 16:35:04 +0000

Status: Started
Owner: address@hidden
Labels: Type-Enhancement Patch-new

New issue 3439 by address@hidden: Patch: Create a two-argument form of define-event-class
http://code.google.com/p/lilypond/issues/detail?id=3439

Create a two-argument form of define-event-class

This definition of define-event-class just specifies the event class
symbol itself as well as its immediate parent class.  Redefining
existing event classes is not (yet?) supported.


I've come to the persuasion that the \DefineEventClass interface was
not a good idea as it introduces a separate event class hierarchy for
every Global context.  Since Global contexts share iterators (which
are part of the music types), that does not make sense.  The previous
approach tried to address the problem of permanent changes
transgressing the lifetime of a session: session variables make for a
better match to that problem.

The old definition of define-event-class was needlessly contorted for
what it allowed: this one is reasonably straightforward.

Also contains commits:


Reinitialize all-event-classes and all-grob-descriptions after session


Revert "Make EventClass hierarchy a property of Global context"

This reverts commit ae2db5b21bf232f5145f3a3e091689c8fc7247e9.

Conflicts:
        lily/context-scheme.cc
        lily/global-context.cc
        lily/music.cc
        lily/part-combine-iterator.cc
        scm/define-event-classes.scm
        scm/document-music.scm

Independently introduced conflict:
        lily/footnote-engraver.cc

http://codereview.appspot.com/10965043

--
You received this message because this project is configured to send all issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings



reply via email to

[Prev in Thread] Current Thread [Next in Thread]